Skip to content

[Fix](Nereids)fix group_concat to support more cases#15815

Merged
morrySnow merged 12 commits intoapache:masterfrom
sohardforaname:gct
Jan 12, 2023
Merged

[Fix](Nereids)fix group_concat to support more cases#15815
morrySnow merged 12 commits intoapache:masterfrom
sohardforaname:gct

Conversation

@sohardforaname
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

fix group_concat to support group_concat(cast(slot), ...) and support call it with 1 argument.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 11, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.02 seconds
load time: 494 seconds
storage size: 17122619863 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112115600_clickbench_pr_78578.html

morrySnow
morrySnow previously approved these changes Jan 11, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 11, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 12, 2023
@morrySnow morrySnow merged commit a7af869 into apache:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants