Skip to content

[improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO#15893

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
yiguolei:add_tid_signal
Jan 14, 2023
Merged

[improvement](signal) add tid during core dump,the tid is equal to thread id in be.INFO#15893
Gabriel39 merged 1 commit intoapache:masterfrom
yiguolei:add_tid_signal

Conversation

@yiguolei
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#ifdef __APPLE__
pthread_threadid_np(nullptr, &tid);
#else
tid = syscall(SYS_gettid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'SYS_gettid' [clang-diagnostic-error]

    tid = syscall(SYS_gettid);
                  ^

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 13, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.58 seconds
load time: 490 seconds
storage size: 17121409397 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230114030621_clickbench_pr_80214.html

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 98c74f9 into apache:master Jan 14, 2023
@yiguolei yiguolei deleted the add_tid_signal branch August 23, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments