Skip to content

[Bug](pipeline) Fix DCHECK failure#15928

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:fix_pip_pendingfinish
Jan 17, 2023
Merged

[Bug](pipeline) Fix DCHECK failure#15928
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:fix_pip_pendingfinish

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

F0113 12:13:40.082304 2620340 task_scheduler.cpp:229] Check failed: !task->is_pending_finish() must not pending close PipelineTask[id = 0, state = PENDING_FINISH]
operators:
ScanOperator, is source: 1, is sink: 0, is closed: 0, is pending finish: 1, scanner_ctx is null: false , num_running_scanners = 1, num_scheduling_ctx = 0
OlapTableSinkOperator, is source: 0, is sink: 1, is closed: 0, is pending finish: 0

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.09 seconds
load time: 495 seconds
storage size: 17123158832 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116180856_clickbench_pr_81500.html

@Gabriel39 Gabriel39 force-pushed the fix_pip_pendingfinish branch from 7d96fd9 to 8ef03ad Compare January 16, 2023 13:47
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 7d34512 into apache:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants