Skip to content

[Enhencement](Push Handle) use VParquetScanner in PushHandle#15980

Merged
yiguolei merged 2 commits intoapache:masterfrom
BePPPower:fixBroker
Jan 17, 2023
Merged

[Enhencement](Push Handle) use VParquetScanner in PushHandle#15980
yiguolei merged 2 commits intoapache:masterfrom
BePPPower:fixBroker

Conversation

@BePPPower
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.08 seconds
load time: 500 seconds
storage size: 17121017887 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230117053322_clickbench_pr_81805.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit bbdf40b into apache:master Jan 17, 2023
@morningman morningman added dev/1.2.2 kind/fix Categorizes issue or PR as related to a bug. labels Jan 17, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 1, 2023
…15980)

* use VParquetScanner in PushHadnle

* delete ParquetScanner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants