[fix](Nereids): add integer type #15983
Merged
morrySnow merged 1 commit intoapache:masterfrom Jan 17, 2023
Merged
Conversation
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morrySnow
reviewed
Jan 16, 2023
| List<Expr> joinConjuncts = nestedLoopJoin.getOtherJoinConjuncts().stream() | ||
| .map(e -> ExpressionTranslator.translate(e, context)).collect(Collectors.toList()); | ||
| nestedLoopJoinNode.setJoinConjuncts(joinConjuncts); | ||
| nestedLoopJoinNode.addConjuncts(joinConjuncts); |
Contributor
There was a problem hiding this comment.
why we put join conjuncts to filter? i don't think it is right
Contributor
|
maybe the right way to fix NLJ is #15979 |
keanji-x
force-pushed
the
fix-q54
branch
2 times, most recently
from
f9741eb to
59e8cb7
Compare
Contributor
Author
Yeah, I'll remove them |
keanji-x
changed the title
morrySnow
approved these changes
Jan 17, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
add integer type
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...