[fix](MTMV) Refine the process of refreshing data#16006
Merged
morningman merged 3 commits intoapache:masterfrom Jan 17, 2023
Merged
[fix](MTMV) Refine the process of refreshing data#16006morningman merged 3 commits intoapache:masterfrom
morningman merged 3 commits intoapache:masterfrom
Conversation
github-actions
bot
added
area/planner
adonis0147
force-pushed
the
mtmv-test
branch
3 times, most recently
from
67cb325 to
cc82305
Compare
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVTaskExecutorPool.java
Show resolved
Hide resolved
Contributor
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
1. Remove some redundant code. 2. Fix the issue with the state of MTMV task. 3. Fix the case - test_create_mtmv. ## Problem summary 1. We used a retry policy to re-run the failed MTMV tasks, but we set the state to `FAILURE` during re-running the tasks. We should do this after all the retry runs fail. 2. There are some redundant code can be removed. 3. In the case test_create_mtmv, we created many background tasks to refresh the data. Some task may fail due to the concurrency and cause the test fail. Actually, we only need single one task to verify the functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
FAILUREduring re-running the tasks. We should do this after all the retry runs fail.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...