Skip to content

[ehancement](nereids) Made the parse for named expression more complete.#16010

Merged
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:fix/alias
Jan 18, 2023
Merged

[ehancement](nereids) Made the parse for named expression more complete.#16010
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:fix/alias

Conversation

@Kikyou1997
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

After this PR, we could support such grammar.

SELECT SUBSTRING("dddd编", 0, 3) AS "测试";
SELECT SUBSTRING("dddd编", 0, 3) "测试";

And remove some function name from keyword list.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 17, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.98 seconds
load time: 504 seconds
storage size: 17122176423 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118050554_clickbench_pr_82843.html

SELECT SUBSTRING("dddd编", 0, 3) AS "测试";
SELECT SUBSTRING("dddd编", 0, 3) "测试";
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 0916cbc into apache:master Jan 18, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 1, 2023
…te (apache#16010)

After this PR, we could support such grammar.

SELECT SUBSTRING("dddd编", 0, 3) AS "测试";
SELECT SUBSTRING("dddd编", 0, 3) "测试";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments