[refactor](remove non vec) remove column block and column view #16022
Merged
yiguolei merged 4 commits intoapache:masterfrom Jan 18, 2023
Merged
[refactor](remove non vec) remove column block and column view #16022yiguolei merged 4 commits intoapache:masterfrom
yiguolei merged 4 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0; | ||
|
|
||
| virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n, |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'rowid_t' [clang-diagnostic-error]
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^|
|
||
| virtual Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) = 0; | ||
|
|
||
| virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n, |
Contributor
There was a problem hiding this comment.
warning: unknown type name 'ordinal_t' [clang-diagnostic-error]
virtual Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal, size_t* n,
^
Contributor
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
…e#16022) * [refactor](remove non vec) remove column block and column view and column vectorized batch Co-authored-by: yiguolei <yiguolei@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...