[fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue#16033
Merged
yiguolei merged 6 commits intoapache:masterfrom Jan 18, 2023
Merged
[fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue#16033yiguolei merged 6 commits intoapache:masterfrom
yiguolei merged 6 commits intoapache:masterfrom
Conversation
morningman
added
area/multi-catalog
dev/1.2.2
kind/fix
Contributor
|
TeamCity pipeline, clickbench performance test result: |
| dataSource = new HikariDataSource(config); | ||
| conn = dataSource.getConnection(); | ||
| conn.setAutoCommit(false); | ||
| if (op == TJdbcOperation.READ) { |
Contributor
There was a problem hiding this comment.
should set it to false only the op==READ
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added a commit
that referenced
this pull request
Jan 23, 2023
…issue (#16033) Fix bug that when create jdbc resource with only jdbc driver file name, it will failed to do checksum This is because we forgot the pass the full driver url to JdbcClient. Add ResultSet.FETCH_FORWARD and set AutoCommit to false to jdbc connection, so to avoid OOM when fetching large amount of data set useCursorFetch in jdbc url for both MySQL and PostgreSQL. Fix some p2 external datasource bug
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
…issue (apache#16033) Fix bug that when create jdbc resource with only jdbc driver file name, it will failed to do checksum This is because we forgot the pass the full driver url to JdbcClient. Add ResultSet.FETCH_FORWARD and set AutoCommit to false to jdbc connection, so to avoid OOM when fetching large amount of data set useCursorFetch in jdbc url for both MySQL and PostgreSQL. Fix some p2 external datasource bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Fix bug that when create jdbc resource with only jdbc driver file name, it will failed to do checksum
This is because we forgot the pass the full driver url to JdbcClient.
Add
ResultSet.FETCH_FORWARDand set AutoCommit to false to jdbc connection, so to avoid OOM when fetching large amount of dataset
useCursorFetchin jdbc url for both MySQL and PostgreSQL.Fix some p2 external datasource bug
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...