Skip to content

[chore](config) set config enable_write_index_searcher_cache default to false, and set config inverted_index_searcher_cache_limit default to 5%#16085

Closed
Tanya-W wants to merge 1 commit intoapache:masterfrom
Tanya-W:dev
Closed

Conversation

@Tanya-W
Copy link
Contributor

@Tanya-W Tanya-W commented Jan 19, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

index_searcher_cache is cache file descriptor of inverted index, if open file descriptor limit of the Linux system is set too small and config inverted_index_searcher_cache_limit is too big, during high pressure load maybe cause "Too many open files".

So set config enable_write_index_searcher_cache default to false, and reduce config inverted_index_searcher_cache_limit default to 5%.

It is recommended to open enable_write_index_searcher_cache when the query pressure is greater than the write pressure.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

qidaye
qidaye previously approved these changes Jan 20, 2023
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

…to false, and set config inverted_index_searcher_cache_limit default to 5%
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Tanya-W Tanya-W closed this Feb 17, 2023
@Tanya-W Tanya-W deleted the dev branch February 20, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants