Skip to content

[fix](Nereids): fix bugs about date function#16109

Closed
keanji-x wants to merge 1 commit intoapache:masterfrom
keanji-x:fix-test-date-func
Closed

[fix](Nereids): fix bugs about date function#16109
keanji-x wants to merge 1 commit intoapache:masterfrom
keanji-x:fix-test-date-func

Conversation

@keanji-x
Copy link
Contributor

@keanji-x keanji-x commented Jan 19, 2023

Proposed changes

  1. Add unixtime type to represent unix-timestamp. It's -1 when the real arguments > INT.MAX. We don't use int because the long value will be cast to INT.MAX and then we always get the largest time 2038-1-19 rather than null
  2. Change the scale of default datev2 from 0 to 6 so we can be compatible the smaller precision

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.43 seconds
load time: 502 seconds
storage size: 17122409472 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119162344_clickbench_pr_84284.html

@keanji-x keanji-x closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants