Skip to content

[fix](meta) Persist storage_medium property for OlapTable and allow partition to inherit it#16198

Closed
zhengshengjun wants to merge 1 commit intoapache:masterfrom
zhengshengjun:persist_storage_medium
Closed

[fix](meta) Persist storage_medium property for OlapTable and allow partition to inherit it#16198
zhengshengjun wants to merge 1 commit intoapache:masterfrom
zhengshengjun:persist_storage_medium

Conversation

@zhengshengjun
Copy link
Member

@zhengshengjun zhengshengjun commented Jan 29, 2023

Persist storage_medium property for OlapTable and allow partition to inherit it

Proposed changes

Currently, 'storage_medium' property in create table statement, is not persisted as table properties.

  • If we set a partitioned table's storage_medium to SSD, the newly added partition will use cluster's default storage_medium(HDD if ont set).
  • If we set an un-partitioned table's storage_medium to SSD, Doris creates a inner partition that use default storage_medium(HDD if ont set) for the table. That cause the storage_medium for un-partitioned table is not effective.

This PR persist storage_medium property for OlapTable and allow partition to inherit this table property.

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.66 seconds
load time: 556 seconds
storage size: 17122766214 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129114836_clickbench_pr_86231.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Aug 5, 2023
@github-actions github-actions bot closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments