Skip to content

[Bug](vectorized)Fix reading date and datetime types conversion error#16252

Merged
yiguolei merged 4 commits intoapache:masterfrom
JNSimba:arrow_date
Feb 4, 2023
Merged

[Bug](vectorized)Fix reading date and datetime types conversion error#16252
yiguolei merged 4 commits intoapache:masterfrom
JNSimba:arrow_date

Conversation

@JNSimba
Copy link
Member

@JNSimba JNSimba commented Jan 30, 2023

Problem summary

from pr #15612, Type conversion error when reading date and datetime types

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Gabriel39
Gabriel39 previously approved these changes Jan 30, 2023
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 30, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 30, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 30, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.15 seconds
load time: 461 seconds
storage size: 17170925209 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230204130057_clickbench_pr_90439.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit c488e67 into apache:master Feb 4, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
…apache#16252)

from pr apache#15612, Type conversion error when reading date and datetime types



---------

Co-authored-by: wudi <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants