Skip to content

[bug](jdbc) fix jdbc insert decimalv3 be core dump#16353

Merged
HappenLee merged 1 commit intoapache:masterfrom
zhangstar333:jdbc_decimalv3_insert
Feb 3, 2023
Merged

[bug](jdbc) fix jdbc insert decimalv3 be core dump#16353
HappenLee merged 1 commit intoapache:masterfrom
zhangstar333:jdbc_decimalv3_insert

Conversation

@zhangstar333
Copy link
Contributor

Proposed changes

*** Query id: bd140aca583140d9-aa826a4ce54283d6 ***
*** Aborted at 1675233072 (unix time) try "date -d @1675233072" if you are using GNU date ***
*** Current BE git commitID: fdb6eff ***
*** SIGSEGV unkown detail explain (@0x0) received by PID 1771670 (TID 1771894 OR 0x7f98dc05c700) from PID 0; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk1/ftw/projects/doris/be/src/common/signal_handler.h:428
 1# os::Linux::chained_handler(int, siginfo*, void*) in /mnt/disk1/ftw/tools/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
 2# JVM_handle_linux_signal in /mnt/disk1/ftw/tools/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
 3# signalHandler(int, siginfo*, void*) in /mnt/disk1/ftw/tools/jdk1.8.0_131/jre/lib/amd64/server/libjvm.so
 4# 0x00007F9938A11C20 in /lib64/libpthread.so.0
 5# doris::vectorized::DataTypeNullable::to_string[abi:cxx11](doris::vectorized::IColumn const&, unsigned long) const at /mnt/disk1/ftw/projects/doris/be/src/vec/data_types/data_type_nullable.cpp:48
 6# doris::TableConnector::convert_column_data(COWdoris::vectorized::IColumn::immutable_ptrdoris::vectorized::IColumn const&, std::shared_ptr<doris::vectorized::IDataType const> const&, doris::TypeDescriptor const&, int, doris::TOdbcTableType::type) at /mnt/disk1/ftw/projects/doris/be/src/exec/table_connector.cpp:279
 7# doris::TableConnector::append(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, doris::vectorized::Block*, std::vector<doris::vectorized::VExprContext*, std::allocatordoris::vectorized::VExprContext* > const&, unsigned int, unsigned int*, doris::TOdbcTableType::type) at /mnt/disk1/ftw/projects/doris/be/src/runtime/types.h:39
 8# doris::vectorized::VJdbcTableSink::send(doris::RuntimeState*, doris::vectorized::Block*, bool) at /mnt/disk1/ftw/projects/doris/be/src/vec/sink/vjdbc_table_sink.cpp:83
 9# doris::PlanFragmentExecutor::open_vectorized_internal() at /mnt/disk1/ftw/projects/doris/be/src/runtime/plan_fragment_executor.cpp:298
10# doris::PlanFragmentExecutor::open() at /mnt/disk1/ftw/projects/doris/be/src/runtime/plan_fragment_executor.cpp:241
11# doris::FragmentExecState::execute() at /mnt/disk1/ftw/projects/doris/be/src/runtime/fragment_mgr.cpp:250
12# doris::FragmentMgr::_exec_actual(std::shared_ptrdoris::FragmentExecState, std::function<void (doris::RuntimeState*, doris::Status*)>) at /mnt/disk1/ftw/projects/doris/be/src/runtime/fragment_mgr.cpp:490
13# std::_Function_handler<void (), doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&, std::function<void (doris::RuntimeState*, doris::Status*)>)::{lambda()#1}>::_M_invoke(std::_Any_data const&) at /mnt/disk1/ftw/tools/ldb_toolchain/include/c++/11/bits/std_function.h:291
14# doris::ThreadPool::dispatch_thread() at /mnt/disk1/ftw/projects/doris/be/src/util/threadpool.cpp:543
15# doris::Thread::supervise_thread(void*) at /mnt/disk1/ftw/projects/doris/be/src/util/thread.cpp:454
16# start_thread in /lib64/libpthread.so.0
17# __GI___clone in /lib64/libc.so.6
Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@BePPPower BePPPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39
Copy link
Contributor

Could you add regression test case?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.1 seconds
load time: 518 seconds
storage size: 17121134677 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230202073441_clickbench_pr_89288.html

@HappenLee HappenLee merged commit 545b91f into apache:master Feb 3, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants