Skip to content

[Feature-WIP](inverted index) support array type for inverted index reader#16355

Merged
dataroaring merged 1 commit intoapache:masterfrom
Tanya-W:inverted-index-array
Feb 2, 2023
Merged

[Feature-WIP](inverted index) support array type for inverted index reader#16355
dataroaring merged 1 commit intoapache:masterfrom
Tanya-W:inverted-index-array

Conversation

@Tanya-W
Copy link
Contributor

@Tanya-W Tanya-W commented Feb 2, 2023

Proposed changes

Issue Number: Step4 of DSIP-023: Add inverted index for full text search
support array type for inverted index reader

dependency pr: #14211 #15823

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Tanya-W Tanya-W force-pushed the inverted-index-array branch from 14dc034 to 263461b Compare February 2, 2023 03:37
@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization kind/test labels Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.53 seconds
load time: 520 seconds
storage size: 17120910804 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230202075550_clickbench_pr_89308.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bb179b7 into apache:master Feb 2, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
@Tanya-W Tanya-W deleted the inverted-index-array branch September 12, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants