Skip to content

[fix](iceberg) fix iceberg catalog rest access#16372

Merged
morningman merged 2 commits intoapache:masterfrom
wsjz:fix_iceberg_catalog
Feb 5, 2023
Merged

[fix](iceberg) fix iceberg catalog rest access#16372
morningman merged 2 commits intoapache:masterfrom
wsjz:fix_iceberg_catalog

Conversation

@wsjz
Copy link
Contributor

@wsjz wsjz commented Feb 2, 2023 •
edited
Loading

Proposed changes

Fix iceberg catalog access s3
Fix iceberg catalog partition table query
Fix persistence

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 2, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.67 seconds
load time: 464 seconds
storage size: 17171288160 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230204152905_clickbench_pr_90463.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@wsjz wsjz marked this pull request as ready for review February 4, 2023 06:19
@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Feb 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman reviewed Feb 5, 2023
View reviewed changes
docs/zh-CN/docs/lakehouse/multi-catalog/iceberg.md
);
```

### 基于Iceberg API创建Catalog
Copy link
Contributor

@morningman morningman Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <version since="dev"> tag

docs/zh-CN/docs/lakehouse/multi-catalog/iceberg.md
"AWS_ACCESS_KEY" = "username"
"AWS_SECRET_KEY" = "password"
"AWS_REGION" = "region-name"
"AWS_ENDPOINT" = "http://endpoint-uri"
Copy link
Contributor

@morningman morningman Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing AWS_CREDENTIALS_PROVIDER config?
And missing English version

Copy link
Contributor Author

@wsjz wsjz Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use DataLakeAWSCredentialsProvider

morningman
morningman approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

PR approved by anyone and no changes requested.

@morningman morningman merged commit b1b2697 into apache:master Feb 5, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Feb 5, 2023
@wsjz @morningman
[fix](iceberg) fix iceberg catalog (apache#16372)
a8772f0 
1. Fix iceberg catalog access s3
2. Fix iceberg catalog partition table query
3. Fix persistence
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
@wsjz
[fix](iceberg) fix iceberg catalog (apache#16372)
c373356 
1. Fix iceberg catalog access s3
2. Fix iceberg catalog partition table query
3. Fix persistence
@wsjz wsjz deleted the fix_iceberg_catalog branch March 28, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/multi-catalog area/vectorization dev/1.2.2-merged kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wsjz @hello-stephen @morningman