[Bug](date) Fix BE crash caused by function datediff#16397
Merged
yiguolei merged 2 commits intoapache:masterfrom Feb 4, 2023
Merged
[Bug](date) Fix BE crash caused by function datediff#16397yiguolei merged 2 commits intoapache:masterfrom
datediff#16397yiguolei merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morningman
pushed a commit
that referenced
this pull request
Feb 5, 2023
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 6, 2023
* [Bug](date) Fix BE crash caused by function `datediff` * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
** Current BE git commitID: dbbb417 ***
*** SIGABRT unkown detail explain (@0x43c000a1ed5) received by PID 663253 (TID 663525 OR 0x7e8a62717700) from PID 663253; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/tengjianping/doris/be/src/common/signal_handler.h:428
1# 0x00007F37EB3E2C20 in /lib64/libpthread.so.0
2# __GI_raise in /lib64/libc.so.6
3# __GI_abort in /lib64/libc.so.6
4# 0x000056540ACBB109 in /mnt/disk2/tengjianping/doris/output/be/lib/doris_be
5# 0x000056540ACB071D in /mnt/disk2/tengjianping/doris/output/be/lib/doris_be
6# google::LogMessage::SendToLog() in /mnt/disk2/tengjianping/doris/output/be/lib/doris_be
7# google::LogMessage::Flush() in /mnt/disk2/tengjianping/doris/output/be/lib/doris_be
8# google::LogMessageFatal::~LogMessageFatal() in /mnt/disk2/tengjianping/doris/output/be/lib/doris_be
9# doris::vectorized::DateTimeOp<long, long, int, doris::vectorized::DateDiffImpl<doris::vectorized::DataTypeDateTime, doris::vectorized::DataTypeDateTime> >::constant_vector(long const&, doris::vectorized::PODArray<int, 4096ul, Allocator<false, false>, 15ul, 16ul>&, doris::vectorized::PODArray<long, 4096ul, Allocator<false, false>, 15ul, 16ul> const&) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function_date_or_datetime_computation.h:439
10# doris::vectorized::DateTimeAddIntervalImpl<long, doris::vectorized::DateDiffImpl<doris::vectorized::DataTypeDateTime, doris::vectorized::DataTypeDateTime>, long>::execute(doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function_date_or_datetime_computation.h:550
11# doris::vectorized::FunctionDateOrDateTimeComputation<doris::vectorized::DateDiffImpl<doris::vectorized::DataTypeDateTime, doris::vectorized::DataTypeDateTime> >::execute_impl(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function_date_or_datetime_computation.h:717
12# doris::vectorized::DefaultExecutable::execute_impl(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function.h:478
13# doris::vectorized::PreparedFunctionImpl::execute_without_low_cardinality_columns(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long, bool) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function.cpp:252
14# doris::vectorized::PreparedFunctionImpl::execute(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long, bool) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function.cpp:274
15# doris::vectorized::IFunctionBase::execute(doris_udf::FunctionContext*, doris::vectorized::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, unsigned long, bool) at /mnt/disk2/tengjianping/doris/be/src/vec/functions/function.h:147
16# doris::vectorized::VectorizedFnCall::execute(doris::vectorized::VExprContext*, doris::vectorized::Block*, int*) at /mnt/disk2/tengjianping/doris/be/src/vec/exprs/vectorized_fn_call.cpp:108
17# doris::vectorized::VectorizedFnCall::execute(doris::vectorized::VExprContext*, doris::vectorized::Block*, int*) at /mnt/disk2/tengjianping/doris/be/src/vec/exprs/vectorized_fn_call.cpp:92
18# doris::vectorized::VExprContext::execute(doris::vectorized::Block*, int*) at /mnt/disk2/tengjianping/doris/be/src/vec/exprs/vexpr_context.cpp:44
19# doris::vectorized::VDataStreamSender::get_partition_column_result(doris::vectorized::Block*, int*) const at /mnt/disk2/tengjianping/doris/be/src/vec/sink/vdata_stream_sender.h:98
20# doris::vectorized::VDataStreamSender::send(doris::RuntimeState*, doris::vectorized::Block*, bool) at /mnt/disk2/tengjianping/doris/be/src/vec/sink/vdata_stream_sender.cpp:513
21# doris::PlanFragmentExecutor::open_vectorized_internal() at /mnt/disk2/tengjianping/doris/be/src/runtime/plan_fragment_executor.cpp:295
22# doris::PlanFragmentExecutor::open() at /mnt/disk2/tengjianping/doris/be/src/runtime/plan_fragment_executor.cpp:237
23# doris::FragmentExecState::execute() at /mnt/disk2/tengjianping/doris/be/src/runtime/fragment_mgr.cpp:250
24# doris::FragmentMgr::_exec_actual(std::shared_ptrdoris::FragmentExecState, std::function<void (doris::RuntimeState*, doris::Status*)>) at /mnt/disk2/tengjianping/doris/be/src/runtime/fragment_mgr.cpp:490
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...