Skip to content

[fix](docs) fix some errors in docs#16546

Merged
jackwener merged 1 commit intoapache:masterfrom
hechao-ustc:doc_fix
Feb 9, 2023
Merged

[fix](docs) fix some errors in docs#16546
jackwener merged 1 commit intoapache:masterfrom
hechao-ustc:doc_fix

Conversation

@hechao-ustc
Copy link
Contributor

@hechao-ustc hechao-ustc commented Feb 9, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

  1. A metric is missing a name;
  2. The data-partition doc has a format error.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Feb 9, 2023
@hechao-ustc
Copy link
Contributor Author

At present, the monitor-metrics document only has content in zh-CN, not in English.

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

PR approved by anyone and no changes requested.

@jackwener jackwener merged commit 21cdbec into apache:master Feb 9, 2023
YangShaw pushed a commit to YangShaw/doris that referenced this pull request Feb 17, 2023
Co-authored-by: hechao <hechao@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants