[fix](merge-on-write) fix that the query result has duplicate keys when load with sequence column#16587
Merged
zhannngchen merged 1 commit intoapache:masterfrom Feb 10, 2023
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…en load with sequence column
ab8bff8 to
9ce31f5
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morningman
pushed a commit
that referenced
this pull request
Feb 10, 2023
…en load with sequence column (#16587)
YangShaw
pushed a commit
to YangShaw/doris
that referenced
this pull request
Feb 17, 2023
…en load with sequence column (apache#16587)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Delete bitmap will be calculate when memtable flush and publish. The two stages may see different versions.
When there is sequence column, the currently imported data of rowset may be marked for deletion at memtablet flush or publish because the seq column is smaller than the previous rowset.
Finally, the real version of delete bitmap will be updated. Because the set operation is used, so the delete bitmap of a certain version is lost.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...