[Bug](cooldown) set new replica id when early exit in doing clone when no missed versions#16644
Merged
yiguolei merged 3 commits intoapache:masterfrom Feb 13, 2023
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
platoneko
reviewed
Feb 12, 2023
13 tasks
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
LGTM |
YangShaw
pushed a commit
to YangShaw/doris
that referenced
this pull request
Feb 17, 2023
…n no missed versions (apache#16644) * set new replica id * reduce lock * reset when replica id is different
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
When doing clone task, the logic would early exit if the missed version is empty. But the tablet meta is not set with the newly replica id inside the clone request. It would result inconsistent cooldown replica id when doing cooldown.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...