Skip to content

[fix](cooldown) Add cold_compaction_lock to serialize any operations which may delete the input rowsets of cold data compaction#16742

Merged
dataroaring merged 2 commits intoapache:masterfrom
platoneko:cold_data_compaction
Feb 14, 2023
Merged

[fix](cooldown) Add cold_compaction_lock to serialize any operations which may delete the input rowsets of cold data compaction#16742
dataroaring merged 2 commits intoapache:masterfrom
platoneko:cold_data_compaction

Conversation

@platoneko
Copy link
Contributor

@platoneko platoneko commented Feb 14, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Add cold_compaction_lock to serialize any operations which may delete the input rowsets of cold data compaction.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Feb 14, 2023
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 14, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7482b6b into apache:master Feb 14, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
…which may delete the input rowsets of cold data compaction (apache#16742)

Add cold_compaction_lock to serialize tablet clone, cold data compaction and follow cooldowned data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants