Skip to content

Conversation

@sohardforaname
Copy link
Contributor

@sohardforaname sohardforaname commented Feb 21, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

add dayofweek for FEFunctions to support fold constant.
use Zellar algorithm

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/sql/function Issues or PRs related to the SQL functions label Feb 21, 2023
@morrySnow
Copy link
Contributor

run buildall

@sohardforaname
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 21, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.76 seconds
stream load tsv: 466 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s
stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230222093025_clickbench_pr_101739.html

@morningman morningman added usercase Important user case type label dev/1.2.3 labels Feb 22, 2023
@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run buildall

@sohardforaname
Copy link
Contributor Author

run p0

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit df2f248 into apache:master Feb 22, 2023
morningman pushed a commit that referenced this pull request Feb 23, 2023
…tant (#16993)

add dayofweek for FEFunctions to support fold constant. use Zellar algorithm
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
…tant (apache#16993)

add dayofweek for FEFunctions to support fold constant. use Zellar algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions dev/1.2.3-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants