Skip to content

[Chore](regression-test) modify expectRelativeError from 1e-10 to 1e-8#17162

Merged
HappenLee merged 1 commit intoapache:masterfrom
BiteTheDDDDt:dev_0227
Feb 27, 2023
Merged

[Chore](regression-test) modify expectRelativeError from 1e-10 to 1e-8#17162
HappenLee merged 1 commit intoapache:masterfrom
BiteTheDDDDt:dev_0227

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

It turns out that the limit on precision error is too strict, this pr is changed to expectRelativeError to relax the limit

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit f26f0a1 into apache:master Feb 27, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@BiteTheDDDDt BiteTheDDDDt deleted the dev_0227 branch January 20, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants