[Feature](Nereids)add check to disable unsupported type for Nereids#17196
Merged
morrySnow merged 27 commits intoapache:masterfrom Mar 3, 2023
Merged
[Feature](Nereids)add check to disable unsupported type for Nereids#17196morrySnow merged 27 commits intoapache:masterfrom
morrySnow merged 27 commits intoapache:masterfrom
Conversation
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
sohardforaname
force-pushed
the
chk
branch
3 times, most recently
from
b7bbbae to
d10ab63
Compare
Contributor
Author
|
run buildall |
2 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
2 similar comments
Contributor
Author
|
run p0 |
Contributor
Author
|
run p0 |
morrySnow
approved these changes
Mar 3, 2023
Comment on lines
+144
to
+145
| // qt_aggregate32" select topn_weighted(c_string,c_bigint,3) from ${tableName}" | ||
| // qt_aggregate33" select avg_weighted(c_double,c_bigint) from ${tableName};" |
Contributor
There was a problem hiding this comment.
avg_weighted do not return array why remove it?
Contributor
Author
There was a problem hiding this comment.
by mistake, because topn_weighted return array
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
1 similar comment
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
1 similar comment
Contributor
|
PR approved by anyone and no changes requested. |
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
1. disable decimalv3 2. disable json 3. disable complex type: array, map, struct 4. disable switch: group_by_and_having_use_alias
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
1. disable decimalv3 2. disable json 3. disable complex type: array, map, struct 4. disable switch: group_by_and_having_use_alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
check output slots of all the node and if unsupported type found, throw an exception.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...