Skip to content

Conversation

@GoGoWen
Copy link
Contributor

@GoGoWen GoGoWen commented Mar 1, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

support show create repository stmt.

SQL example: show create repository for repo_name
Result:
MySQL [(none)]> show create repository for doris_backup_backup_cluster_bt1;
+---------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| RepoName | CreateStmt |
+---------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| doris_backup_backup_cluster_bt1 | create read only repository doris_backup_backup_cluster_bt1 with broker broker_name on location "hdfs://ns1017/user/jd_ad/ads_report/narwal_backup/backup_cluster" properties ("password" = "XXXX","dfs.client.failover.proxy.provider" = "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider","dfs.ha.namenodes.ns1017" = "nn1,nn2","dfs.namenode.rpc-address.ns1017.nn2" = "XXXXXX:8020","dfs.nameservices" = "ns1017","dfs.namenode.rpc-address.ns1017.nn1" = "XXXXX:8020","username" = "XXXX") |
+---------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Checklist(Required)

  • [N ] Does it affect the original behavior
  • [ N] Has unit tests been added
  • [N ] Has document been added or modified
  • [N ] Does it need to update dependencies
  • [Y] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Mar 1, 2023
@GoGoWen GoGoWen changed the title support show create repository [Enhancement] (Backup) support show create repository Mar 1, 2023
@GoGoWen GoGoWen changed the title [Enhancement] (Backup) support show create repository [Enhancement](Backup) support show create repository Mar 1, 2023
@morningman morningman self-assigned this Apr 8, 2023
@GoGoWen GoGoWen force-pushed the support_show_create_repository branch from 72a7a1e to 2e66aea Compare April 8, 2023 02:49
@morningman
Copy link
Contributor

run buildall

@morningman
Copy link
Contributor

Need to use PrintableMap to print properties, to hide sensitive properties.

@GoGoWen GoGoWen force-pushed the support_show_create_repository branch from 2e66aea to 1f237d4 Compare April 10, 2023 02:36
@GoGoWen
Copy link
Contributor Author

GoGoWen commented Apr 10, 2023

Need to use PrintableMap to print properties, to hide sensitive properties.

Done

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.54 seconds
stream load tsv: 427 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230410045843_clickbench_pr_126765.html

@morningman morningman merged commit a6d25ef into apache:master Apr 10, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.2.4 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants