Skip to content

[Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…#17325

Merged
yiguolei merged 1 commit intoapache:masterfrom
eldenmoon:master
Mar 3, 2023
Merged

[Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…#17325
yiguolei merged 1 commit intoapache:masterfrom
eldenmoon:master

Conversation

@eldenmoon
Copy link
Member

…e` then the block column values could be empty

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 2, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.57 seconds
stream load tsv: 475 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230302075654_clickbench_pr_107031.html

@eldenmoon
Copy link
Member Author

run p0

…e` then the block column values could be empty
@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

run p0

@morningman morningman added usercase Important user case type label dev/1.2.3 labels Mar 3, 2023
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 94e9a22 into apache:master Mar 3, 2023
morningman pushed a commit that referenced this pull request Mar 6, 2023
…e` then the block column values could be empty (#17325)
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Mar 6, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization dev/1.2.3-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants