[enhancement](timeout) replace query timeout with exec timeout#17360
Merged
dataroaring merged 4 commits intoapache:masterfrom Mar 5, 2023
Merged
[enhancement](timeout) replace query timeout with exec timeout#17360dataroaring merged 4 commits intoapache:masterfrom
dataroaring merged 4 commits intoapache:masterfrom
Conversation
Collaborator
Author
|
run buildall |
Hastyshell
changed the title
Hastyshell
changed the title
Collaborator
Author
|
run p0 |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Collaborator
Author
|
run p0 |
1 similar comment
Collaborator
Author
|
run p0 |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run p0 |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run p0 |
Collaborator
Author
|
run arm |
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
qidaye
pushed a commit
to qidaye/incubator-doris
that referenced
this pull request
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
introduce: #16343
Problem summary
pr #16343 made an api-change, use execution_timeout to enrich the semantics of original query_timeout, and execution_timeout got a more general semantics than query_timeout. When I was working with MasterOpExecutor, I found that when forwarding to master, the timeout used for controlling the connection is still query_timeout.
Therefore, I made some updates related to this feature.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...