[enhancement](stream load pipe) using queryid or load id to identify stream load pipe instead of fragment instance id#17362
Merged
yiguolei merged 2 commits intoapache:masterfrom Mar 4, 2023
Conversation
github-actions
bot
added
the
area/planner
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
./run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
force-pushed
the
add_query_id_to_load
branch
from
eaae6dd to
d7a9163
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
force-pushed
the
add_query_id_to_load
branch
from
d7a9163 to
f25d259
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
force-pushed
the
add_query_id_to_load
branch
from
66f2aac to
55d2612
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
./run buildall |
Contributor
Author
|
./run p0 |
…stream load pipe instead of fragment instance id
yiguolei
force-pushed
the
add_query_id_to_load
branch
from
e2f72d9 to
b0c95ce
Compare
Contributor
Author
|
./run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
5 tasks
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…stream load pipe instead of fragment instance id (apache#17362) * [enhancement](stream load pipe) using queryid or load id to identify stream load pipe instead of fragment instance id NewLoadStreamMgr already has pipe and other info. Do not need save the pipe into fragment state. and FragmentState should be more clear. But this pr will change the behaviour of BE. I will pick the pr to doris 1.2.3 and add the load id to FE support. The user could upgrade from 1.2.3 to 2.x Co-authored-by: yiguolei <yiguolei@gmail.com>
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…stream load pipe instead of fragment instance id (apache#17362) * [enhancement](stream load pipe) using queryid or load id to identify stream load pipe instead of fragment instance id NewLoadStreamMgr already has pipe and other info. Do not need save the pipe into fragment state. and FragmentState should be more clear. But this pr will change the behaviour of BE. I will pick the pr to doris 1.2.3 and add the load id to FE support. The user could upgrade from 1.2.3 to 2.x Co-authored-by: yiguolei <yiguolei@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
NewLoadStreamMgr already has pipe and other info. Do not need save the pipe into fragment state. and FragmentState should be more clear.
But this pr will change the behaviour of BE.
I will pick the pr to doris 1.2.3 and add the load id to FE support. The user could upgrade from 1.2.3 to 2.x
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...