Skip to content

[fix](log) use logger to replace printStackTrace()#17382

Merged
yiguolei merged 2 commits intoapache:masterfrom
Cai-Yao:fix_03_03
Mar 3, 2023
Merged

[fix](log) use logger to replace printStackTrace()#17382
yiguolei merged 2 commits intoapache:masterfrom
Cai-Yao:fix_03_03

Conversation

@Cai-Yao
Copy link
Contributor

@Cai-Yao Cai-Yao commented Mar 3, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Use Logger to replace printStackTrace to better locate problems.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner labels Mar 3, 2023
throw e;
} catch (UserException e) {
e.printStackTrace();
// analysis exception only print message, not print the stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add e to log warn

@Cai-Yao
Copy link
Contributor Author

Cai-Yao commented Mar 3, 2023

run buildall

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit b5b5955 into apache:master Mar 3, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
Use Logger to replace printStackTrace to better locate problems.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Use Logger to replace printStackTrace to better locate problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/nereids area/planner Issues or PRs related to the query planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants