Skip to content

Revert "[cherry-pick](load) cherry-pick add submitter and comments to load job to branch-1.2-lts"#17440

Merged
morningman merged 1 commit intobranch-1.2-ltsfrom
revert-17396-branch-1.2
Mar 6, 2023
Merged

Revert "[cherry-pick](load) cherry-pick add submitter and comments to load job to branch-1.2-lts"#17440
morningman merged 1 commit intobranch-1.2-ltsfrom
revert-17396-branch-1.2

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Mar 6, 2023

Reverts #17396
This PR change the meta version, should not backport to 1.2 branch

Alternative:
For 1.2, you can put submitter and comments info in jobProperties of LoadJob, so that we don't need to upgrade metaversion. Because jobProperties is a map.

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load kind/docs Categorizes issue or PR as related to documentation. labels Mar 6, 2023
@morningman morningman merged commit 7d765ad into branch-1.2-lts Mar 6, 2023
@adonis0147 adonis0147 deleted the revert-17396-branch-1.2 branch November 13, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant