-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](olap) The 'scan key' generated by the 'is null' expression causes incorrect query results #17569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
| ) duplicate key(id) | ||
| DISTRIBUTED BY HASH(id) buckets 1 | ||
| PROPERTIES ("replication_allocation" = "tag.location.default: 1"); | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value column is not the key column, the scan key does have affect on this?
I think it's better to add a case that the predicate column is nullable and it is also part of duplcate column.
|
TeamCity pipeline, clickbench performance test result: |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
…es incorrect query results
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…es incorrect query results (#17569)
…es incorrect query results (apache#17569)
Proposed changes
Issue Number: close #17568
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...