Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 8, 2023

Proposed changes

Issue Number: close #17568

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

) duplicate key(id)
DISTRIBUTED BY HASH(id) buckets 1
PROPERTIES ("replication_allocation" = "tag.location.default: 1");
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value column is not the key column, the scan key does have affect on this?
I think it's better to add a case that the predicate column is nullable and it is also part of duplcate column.

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 8, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.26 seconds
stream load tsv: 464 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230309065352_clickbench_pr_111224.html

@morningman morningman added usercase Important user case type label dev/1.2.3 labels Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 9, 2023

run buildall

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 08f0170 into apache:master Mar 10, 2023
morningman pushed a commit that referenced this pull request Mar 10, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.3-merged kind/test reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Got incorrect result with scan keys for boolean column

4 participants