[Optimize](functions)Reconstruct basic process for default function implementation.#17830
Merged
HappenLee merged 1 commit intoapache:masterfrom Mar 17, 2023
Merged
[Optimize](functions)Reconstruct basic process for default function implementation.#17830HappenLee merged 1 commit intoapache:masterfrom
HappenLee merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
area/sql/function
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
HappenLee
reviewed
Mar 15, 2023
zclllyybb
changed the title
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
1 similar comment
Contributor
|
PR approved by anyone and no changes requested. |
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
The constant/nullable deal logic relies on weird recursion. And to avoid infinite recursion, we need an unequal logic for const columns. Now we don't anymore.
After, all const-constraint could and must be dealt with in
get_arguments_that_are_always_constant.Checklist(Required)
Further comments
need to fix scattered checks in functions.