Skip to content

[ehancement](fe) remove lock in statistics cache loader #17834

Merged
yiguolei merged 1 commit intoapache:opt_dict_perffrom
Kikyou1997:fix/remove_lock_perf
Mar 16, 2023
Merged

[ehancement](fe) remove lock in statistics cache loader #17834
yiguolei merged 1 commit intoapache:opt_dict_perffrom
Kikyou1997:fix/remove_lock_perf

Conversation

@Kikyou1997
Copy link
Contributor

Proposed changes

  1. remove the redandunt lock in the CacheLoader, since it use the forkjoinpool in default
  2. Add execute time log for collect stats
  3. Avoid submit duplicate task, when there already has a task to load for the same column

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997 Kikyou1997 force-pushed the fix/remove_lock_perf branch from cf63872 to c3294aa Compare March 15, 2023 14:12
@morningman
Copy link
Contributor

wrong branch

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit e1fe9b1 into apache:opt_dict_perf Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants