Skip to content

[fix](multi-catalog) when checkProperties failed,will have dirty data#17877

Merged
morningman merged 4 commits intoapache:masterfrom
zddr:catalog_bugfix
Mar 22, 2023
Merged

[fix](multi-catalog) when checkProperties failed,will have dirty data#17877
morningman merged 4 commits intoapache:masterfrom
zddr:catalog_bugfix

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Mar 16, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zddr
Copy link
Contributor Author

zddr commented Mar 16, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 16, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.18 seconds
stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230320054940_clickbench_pr_117159.html

@zddr
Copy link
Contributor Author

zddr commented Mar 17, 2023

run p0

@zddr
Copy link
Contributor Author

zddr commented Mar 17, 2023

run buildall

@zddr zddr requested a review from morningman March 17, 2023 02:10
@zddr
Copy link
Contributor Author

zddr commented Mar 17, 2023

run buildall

1 similar comment
@zddr
Copy link
Contributor Author

zddr commented Mar 19, 2023

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zddr
Copy link
Contributor Author

zddr commented Mar 20, 2023

run buildall

@morningman morningman merged commit 7ddba7b into apache:master Mar 22, 2023
@zddr zddr deleted the catalog_bugfix branch March 28, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.3 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants