Skip to content

Conversation

@SaintBacchus
Copy link
Contributor

@SaintBacchus SaintBacchus commented Mar 23, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

MTMV regresiion will loop forever when some bug cause the state not change.

So add a timeout to avoid endless loop. Now it's hard code of 30 mins.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@SaintBacchus
Copy link
Contributor Author

run buildall

@SaintBacchus
Copy link
Contributor Author

run p1

@SaintBacchus SaintBacchus changed the title [Regression](MTMV)Add a retry times for mtmv regression [Regression](MTMV)Add timeout for mtmv regression Mar 23, 2023
Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonis0147 adonis0147 changed the title [Regression](MTMV)Add timeout for mtmv regression [enhancement](MTMV) Add timeout for regression tests Mar 24, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 changed the title [enhancement](MTMV) Add timeout for regression tests [enhancement](MTMV) Add timeouts for regression tests Mar 24, 2023
@adonis0147 adonis0147 changed the title [enhancement](MTMV) Add timeouts for regression tests [enhancement](MTMV) Add a timeout for regression tests Mar 24, 2023
@adonis0147 adonis0147 merged commit a65616a into apache:master Mar 24, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
MTMV regression tests may loop forever due to some potential bugs. Therefore, we add a timeout to avoid endless loop. The value of the timeout is hard coded 30 minutes now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants