-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement](multi catalog) Support hive meta cache TTL #18102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f8decb3 to
50b7866
Compare
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java
Show resolved
Hide resolved
50b7866 to
76a5453
Compare
fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java
Outdated
Show resolved
Hide resolved
|
run buildall |
602e0ae to
29f7b92
Compare
|
run buildall |
1 similar comment
|
run buildall |
dutyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4b3adfd to
b76ecc9
Compare
|
To implement this solution, the system would set the value corresponding to Guava's expireAfterAccess to the configuration value. Guava is a widely used open-source library for Java, which provides various utilities including caching mechanisms. The expireAfterAccess configuration in Guava's cache mechanism specifies the duration after which a cache entry will be automatically removed from the cache if it has not been accessed during that time. |
b76ecc9 to
3b9a6b0
Compare
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java
Outdated
Show resolved
Hide resolved
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
1 similar comment
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
1 similar comment
|
run buildall |
3b9a6b0 to
bc93908
Compare
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
Currently, if user modify the file on hdfs directly, no through hive. The changes of file will not be noticed by Doris and user will get wrong data. Support the TTL(Time-to-Live) config of File Cache, so that the stale file info will be invalidated automatically after expiring. 1.Add a parameter configuration to set file cache ttl. "file.meta.cache.ttl-second". 2.Set the value corresponding to guava expireAfterAccess to the configuration value. Co-authored-by: lexluo <lexluo@tencent.com>
Proposed changes
Issue Number: #17947
Currently, if user modify the file on hdfs directly, no through hive. The changes of file will not be noticed by Doris and user
will get wrong data. Support the TTL(Time-to-Live) config of File Cache, so that the stale file info will be invalidated automatically after expiring.
Problem summary
1.Add a parameter configuration to set file cache ttl. "file.meta.cache.ttl-second".
2.Set the value corresponding to guava expireAfterAccess to the configuration value.
Checklist(Required)
Further comments