Skip to content

[fix](bitmapfilter) fix bitmap filter timeout unit error #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 25, 2023
Merged

[fix](bitmapfilter) fix bitmap filter timeout unit error #18110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/exprs/runtime_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,7 +1109,7 @@ bool IRuntimeFilter::await() {
DCHECK(is_consumer());
// bitmap filter is precise filter and only filter once, so it must be applied.
int64_t wait_times_ms = _wrapper->get_real_type() == RuntimeFilterType::BITMAP_FILTER
? _state->execution_timeout()
? _state->execution_timeout() * 1000
: _state->runtime_filter_wait_time_ms();
if (_state->enable_pipeline_exec()) {
auto expected = _rf_state_atomic.load(std::memory_order_acquire);
Expand Down Expand Up @@ -1159,7 +1159,7 @@ bool IRuntimeFilter::is_ready_or_timeout() {
auto cur_state = _rf_state_atomic.load(std::memory_order_acquire);
// bitmap filter is precise filter and only filter once, so it must be applied.
int64_t wait_times_ms = _wrapper->get_real_type() == RuntimeFilterType::BITMAP_FILTER
? _state->execution_timeout()
? _state->execution_timeout() * 1000
: _state->runtime_filter_wait_time_ms();
int64_t ms_since_registration = MonotonicMillis() - registration_time_;
if (!_state->enable_pipeline_exec()) {
Expand Down