Skip to content

[Improvement] add show data types stmt#18111

Merged
dataroaring merged 13 commits intoapache:masterfrom
ZashJie:show_data_types
Mar 26, 2023
Merged

[Improvement] add show data types stmt#18111
dataroaring merged 13 commits intoapache:masterfrom
ZashJie:show_data_types

Conversation

@ZashJie
Copy link
Contributor

@ZashJie ZashJie commented Mar 25, 2023

Support show data types.
mysql> show data types;
+----------------+------+
| TypeName | Size |
+----------------+------+
| ARRAY | 32 |
| BIGINT | 8 |
| BITMAP | 16 |
| BOOLEAN | 1 |
| CHAR | 16 |
| DATE | 16 |
| DATETIME | 16 |
| DATETIMEV2 | 8 |
| DATEV2 | 4 |
| DECIMAL128 | 16 |
| DECIMAL32 | 4 |
| DECIMAL64 | 8 |
| DECIMALV2 | 16 |
| DOUBLE | 8 |
| FLOAT | 4 |
| HLL | 16 |
| INT | 4 |
| JSONB | 16 |
| LARGEINT | 16 |
| MAP | 24 |
| NULL_TYPE | 1 |
| QUANTILE_STATE | 16 |
| SMALLINT | 2 |
| STRING | 16 |
| TIME | 8 |
| TIMEV2 | 8 |
| TINYINT | 1 |
| VARCHAR | 16 |
| VARIANT | 24 |
+----------------+------+

Proposed changes

Issue Number: close #17920

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. labels Mar 25, 2023
@dataroaring
Copy link
Contributor

  1. please add a regression test; 2. Can we show data types order by name ? if no we should return list order by name by default.

@dataroaring dataroaring added the api-review Categorizes an issue or PR as actively needing an API review. label Mar 25, 2023
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.87 seconds
stream load tsv: 472 seconds loaded 74807831229 Bytes, about 151 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230326034959_clickbench_pr_120695.html

@dataroaring dataroaring merged commit 2a0890d into apache:master Mar 26, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] add one show data types stmt

3 participants