[optimize](function) optimize array_sort using qsort instead of bubble sort#18123
Merged
yiguolei merged 1 commit intoapache:masterfrom Mar 29, 2023
Merged
[optimize](function) optimize array_sort using qsort instead of bubble sort#18123yiguolei merged 1 commit intoapache:masterfrom
yiguolei merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 25, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 25, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…e sort apache#18123 Optimize array_sort (1) optimize array_sort using qsort instead of bubble sort (2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Optimize array_sort
(1) optimize array_sort using qsort instead of bubble sort
(2) Simplifies the handling of null values, because nullable column already supports the sorting process for null value comparisons.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...