Skip to content

[fix](nested_loop_join) got incorrect result from nested loop join without condition #18139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 1 commit into from
Mar 28, 2023
Merged

[fix](nested_loop_join) got incorrect result from nested loop join without condition #18139

Gabriel39 merged 1 commit into from
Mar 28, 2023

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 27, 2023

Proposed changes

The visited flag was not set during the join operation in the absence of a condition, which led to an invalid result.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg force-pushed the fix_nested_loop_join branch from 26b3765 to b7721cc Compare March 27, 2023 09:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg force-pushed the fix_nested_loop_join branch from b7721cc to 0dbbba2 Compare March 28, 2023 02:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor

Gabriel39 commented Mar 28, 2023

run buildall

@yiguolei yiguolei added the usercase Important user case type label label Mar 28, 2023
Gabriel39
Gabriel39 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 28, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.44 seconds
stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230328051000_clickbench_pr_121593.html

@Gabriel39 Gabriel39 merged commit d27201f into apache:master Mar 28, 2023
yagagagaga added a commit to yagagagaga/doris that referenced this pull request Mar 28, 2023
@yagagagaga
[test](order by) add a suit for apache#18139
118b3d2
morningman pushed a commit that referenced this pull request Mar 28, 2023
@mrhhsg @morningman
[fix](nested_loop_join)got incorrect result from nested loop join wit…
2d52a5d 
…hout condition (#18139)
@morningman morningman mentioned this pull request Mar 29, 2023
Closed
5 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
@mrhhsg @yagagagaga
[fix](nested_loop_join)got incorrect result from nested loop join wit…
6876e54 
…hout condition (apache#18139)
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
@mrhhsg @yagagagaga
[fix](nested_loop_join)got incorrect result from nested loop join wit…
136fa6b 
…hout condition (apache#18139)
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
@mrhhsg @yagagagaga
[fix](nested_loop_join)got incorrect result from nested loop join wit…
6922df0 
…hout condition (apache#18139)
@yagagagaga yagagagaga mentioned this pull request Mar 31, 2023
Closed
5 tasks
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@mrhhsg @gnehil
[fix](nested_loop_join)got incorrect result from nested loop join wit…
f3fc6d4 
…hout condition (apache#18139)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
@mrhhsg
[fix](nested_loop_join)got incorrect result from nested loop join wit…
20c28c9 
…hout condition (apache#18139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/vectorization dev/1.2.4-merged kind/test reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrhhsg @Gabriel39 @hello-stephen @morningman @yiguolei