Skip to content

[enhancement](profile) add blocks produced profile to track if output block is very small#18217

Merged
Gabriel39 merged 2 commits intoapache:masterfrom
yiguolei:master
Mar 30, 2023
Merged

[enhancement](profile) add blocks produced profile to track if output block is very small#18217
Gabriel39 merged 2 commits intoapache:masterfrom
yiguolei:master

Conversation

@yiguolei
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Sometimes our output block is very small, should add a counter to diagnose this problem.

And also, I find the profile counter total time and fragment cpu time is very difficult to under stand so that I refactor these code.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.02 seconds
stream load tsv: 446 seconds loaded 74807831229 Bytes, about 159 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230329110946_clickbench_pr_122366.html

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 3094815 into apache:master Mar 30, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants