Skip to content

[Enhancement](Nereids)add datelikev2 type support for fold constant.#18275

Merged
englefly merged 1 commit intoapache:masterfrom
sohardforaname:add_v2
Apr 3, 2023
Merged

[Enhancement](Nereids)add datelikev2 type support for fold constant.#18275
englefly merged 1 commit intoapache:masterfrom
sohardforaname:add_v2

Conversation

@sohardforaname
Copy link
Contributor

@sohardforaname sohardforaname commented Mar 31, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

add datelikev2 type support for fold constant.
date_add / years_add / mouths_add / days_add / hours_add / minutes_add / seconds_add and xxx_sub.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@sohardforaname
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.34 seconds
stream load tsv: 449 seconds loaded 74807831229 Bytes, about 158 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230331075112_clickbench_pr_123244.html


@ExecFunction(name = "date_sub", argTypes = { "DATE", "INT" }, returnType = "DATE")
public static DateLiteral dateSub(DateLiteral date, IntegerLiteral day) throws AnalysisException {
@ExecFunction(name = "date_sub", argTypes = { "DATEV2", "INT" }, returnType = "DATEV2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to line595-599 to line 604 in order to save review effort.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by at least one committer and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by anyone and no changes requested.

@englefly englefly merged commit 4fcd93a into apache:master Apr 3, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…pache#18275

add datelikev2 type support for fold constant.
date_add / years_add / mouths_add / days_add / hours_add / minutes_add / seconds_add and xxx_sub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants