Skip to content

[typo](doc)Small typos in docker run commands.#18288

Merged
luzhijing merged 2 commits intoapache:masterfrom
sepastian:patch-1
Apr 5, 2023
Merged

[typo](doc)Small typos in docker run commands.#18288
luzhijing merged 2 commits intoapache:masterfrom
sepastian:patch-1

Conversation

@sepastian
Copy link
Contributor

@sepastian sepastian commented Mar 31, 2023

In Docker run commands, blanks before "" were missing.

Proposed changes

Issue Number: close #xxx

Problem summary

Fixing small typos in docs about Docker deployment.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Blanks before "\" were missing.
@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Mar 31, 2023
@luzhijing luzhijing changed the title Small typos in docker run commands. [typo](doc)Small typos in docker run commands. Apr 5, 2023
@luzhijing
Copy link
Contributor

There are some conflicts and you should resolve it and rebase the code.

Copy link
Contributor

@luzhijing luzhijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luzhijing
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

PR approved by anyone and no changes requested.

@luzhijing luzhijing merged commit d12c4c6 into apache:master Apr 5, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants