Skip to content

Conversation

@JackDrogon
Copy link
Contributor

@JackDrogon JackDrogon commented Mar 31, 2023

Problem summary

when dynamic partition no bucket setting, set by distribution

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

dynamic_partition.buckets, set by distributionInfo

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@dataroaring dataroaring changed the title Fix dynamic partition no bucket [improvement](dynamic partition) Fix dynamic partition no bucket Apr 1, 2023
@dataroaring
Copy link
Contributor

run buildall

dataroaring
dataroaring previously approved these changes Apr 1, 2023
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

PR approved by anyone and no changes requested.

@dataroaring dataroaring self-assigned this Apr 1, 2023
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 1, 2023
@JackDrogon
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7d49d9c into apache:master Apr 2, 2023
morningman pushed a commit that referenced this pull request Apr 9, 2023
)


Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…che#18300)


Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants