Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

HiveMetastoreCache type for file split was Hadoop InputSplit. In this pr, change it to Doris defined Split
This change could avoid convert it every time.
Also fix the explain verbose result return -1 for split file length.

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Apr 2, 2023
morningman
morningman previously approved these changes Apr 3, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 3, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 32.98 seconds
stream load tsv: 457 seconds loaded 74807831229 Bytes, about 156 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230403042035_clickbench_pr_123938.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 3, 2023
@Jibing-Li
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit e260dca into apache:master Apr 3, 2023
@Jibing-Li Jibing-Li deleted the length branch April 3, 2023 11:10
Mryange pushed a commit to Mryange/doris that referenced this pull request Apr 4, 2023
…ype to Doris defined Split. Fix split file length -1 bug (apache#18319)

HiveMetastoreCache type for file split was Hadoop InputSplit. In this pr, change it to Doris defined Split
This change could avoid convert it every time.
Also fix the explain verbose result return -1 for split file length.
morningman pushed a commit that referenced this pull request Apr 12, 2023
…ype to Doris defined Split. Fix split file length -1 bug (#18319)

HiveMetastoreCache type for file split was Hadoop InputSplit. In this pr, change it to Doris defined Split
This change could avoid convert it every time.
Also fix the explain verbose result return -1 for split file length.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…ype to Doris defined Split. Fix split file length -1 bug (apache#18319)

HiveMetastoreCache type for file split was Hadoop InputSplit. In this pr, change it to Doris defined Split
This change could avoid convert it every time.
Also fix the explain verbose result return -1 for split file length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants