Skip to content

Comments

[fix](alter inverted index) Temporary deal with add or drop inverted index by directly schema change#18378

Merged
qidaye merged 1 commit intoapache:masterfrom
Tanya-W:fix
Apr 6, 2023
Merged

[fix](alter inverted index) Temporary deal with add or drop inverted index by directly schema change#18378
qidaye merged 1 commit intoapache:masterfrom
Tanya-W:fix

Conversation

@Tanya-W
Copy link
Contributor

@Tanya-W Tanya-W commented Apr 4, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

In the current implementation of the function of dynamically add and drop inverted index, there is a problem that the inverted index information of historical data is out of date after compaction on the base tablet.

In the future, I will submit PRs to solve this problem. Now, temporarily add or drop inverted index by the directly schema change logic

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

xiaokang
xiaokang previously approved these changes Apr 4, 2023
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

PR approved by anyone and no changes requested.

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Apr 4, 2023

run buildall

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Apr 5, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Tanya-W
Copy link
Contributor Author

Tanya-W commented Apr 6, 2023

run p0

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 591f76a into apache:master Apr 6, 2023
@Tanya-W Tanya-W deleted the fix branch April 12, 2023 08:03
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…index by directly schema change (apache#18378)

In the current implementation of the function of dynamically add and drop inverted index, there is a problem that the inverted index information of historical data is out of date after compaction on the base tablet.

In the future, I will submit PRs to solve this problem. Now, temporarily add or drop inverted index by the directly schema change logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants