Skip to content

[fix](catalog)Use hive-catalog-shade to solve thrift version compatibility issues#18504

Merged
morningman merged 8 commits intoapache:masterfrom
CalvinKirs:thrift-hive
Apr 11, 2023
Merged

[fix](catalog)Use hive-catalog-shade to solve thrift version compatibility issues#18504
morningman merged 8 commits intoapache:masterfrom
CalvinKirs:thrift-hive

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Apr 10, 2023

Hive 3 uses the thrift-0.9.3 package, and Doris uses the thrift-0.16.0 package. These two packages are not compatible, so we use the hive-sahde package to manage hive dependencies in a unified way. This jar package renames the thrift class , so the problem of conflict can be resolved.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@CalvinKirs
Copy link
Member Author

run buildall

@CalvinKirs
Copy link
Member Author

run buildall

1 similar comment
@CalvinKirs
Copy link
Member Author

run buildall

@CalvinKirs
Copy link
Member Author

run p0

@CalvinKirs
Copy link
Member Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 5f981b0 into apache:master Apr 11, 2023
@CalvinKirs CalvinKirs deleted the thrift-hive branch April 11, 2023 05:21
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…ility issues (apache#18504)

`Hive 3` uses the `thrift-0.9.3` package, and `Doris` uses the `thrift-0.16.0` package.
These two packages are not compatible, so we use the `hive-sahde` package to manage hive dependencies
in a unified way. This jar package renames the `thrift` class , so the problem of conflict can be resolved.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…ility issues (apache#18504)

`Hive 3` uses the `thrift-0.9.3` package, and `Doris` uses the `thrift-0.16.0` package.
These two packages are not compatible, so we use the `hive-sahde` package to manage hive dependencies
in a unified way. This jar package renames the `thrift` class , so the problem of conflict can be resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants