Skip to content

[fix](nereids)remove redundant session Var ENABLE_NEREIDS_RUNTIME_FILTER#18523

Merged
englefly merged 3 commits intoapache:masterfrom
englefly:remove-nereids-RF-sessionVar
Apr 11, 2023
Merged

[fix](nereids)remove redundant session Var ENABLE_NEREIDS_RUNTIME_FILTER#18523
englefly merged 3 commits intoapache:masterfrom
englefly:remove-nereids-RF-sessionVar

Conversation

@englefly
Copy link
Contributor

Proposed changes

ENABLE_NEREIDS_RUNTIME_FILTER is duplicated to runtime_filter_mode.
remove ENABLE_NEREIDS_RUNTIME_FILTER.

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@englefly
Copy link
Contributor Author

run buildall

@englefly englefly changed the title [fix](nereids)remove redunant session Var ENABLE_NEREIDS_RUNTIME_FILTER [fix](nereids)remove redundant session Var ENABLE_NEREIDS_RUNTIME_FILTER Apr 10, 2023
@englefly
Copy link
Contributor Author

run buildall

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 11, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.57 seconds
stream load tsv: 431 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230411071040_clickbench_pr_127330.html

@englefly
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit 876b4ef into apache:master Apr 11, 2023
@englefly englefly deleted the remove-nereids-RF-sessionVar branch April 11, 2023 10:50
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…TER (apache#18523)

remove redundant session Var ENABLE_NEREIDS_RUNTIME_FILTER
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…TER (apache#18523)

remove redundant session Var ENABLE_NEREIDS_RUNTIME_FILTER
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants