Skip to content

Comments

[minor](test) remove unused function to improve test coverage#18598

Merged
HappenLee merged 1 commit intoapache:masterfrom
Gabriel39:mimor_update
Apr 13, 2023
Merged

[minor](test) remove unused function to improve test coverage#18598
HappenLee merged 1 commit intoapache:masterfrom
Gabriel39:mimor_update

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

remove unused function to improve test coverage

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

run buildall

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 2ae0bb7 into apache:master Apr 13, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants