[Refact](type system) refact serde for type system and pb serde impl by amorynan · Pull Request #18627 · apache/doris

amorynan · 2023-04-13T06:37:56Z

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

github-actions

clang-tidy made some suggestions

be/src/vec/data_types/serde/data_type_array_serde.h

be/src/vec/data_types/serde/data_type_decimal_serde.h

be/src/vec/data_types/serde/data_type_map_serde.h

be/src/vec/data_types/serde/data_type_object_serde.h

be/src/vec/data_types/serde/data_type_struct_serde.h

github-actions

clang-tidy made some suggestions

be/src/vec/data_types/serde/data_type_serde.cpp

be/src/vec/data_types/data_type_struct.h

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

clang-tidy made some suggestions

be/src/vec/data_types/serde/data_type_decimal_serde.h

be/src/vec/data_types/serde/data_type_serde.cpp

github-actions · 2023-04-14T01:13:34Z

clang-tidy review says "All clean, LGTM! 👍"

be/src/vec/data_types/serde/data_type_bitmap_serde.cpp

be/src/vec/data_types/serde/data_type_decimal_serde.h

be/src/vec/data_types/serde/data_type_hll_serde.cpp

be/src/vec/functions/function_rpc.cpp

github-actions · 2023-04-15T14:40:08Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-04-17T02:14:51Z

clang-tidy review says "All clean, LGTM! 👍"

amorynan · 2023-04-17T02:32:06Z

run buildall

hello-stephen · 2023-04-17T03:34:56Z

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.31 seconds
stream load tsv: 433 seconds loaded 74807831229 Bytes, about 164 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417102843_clickbench_pr_130126.html

amorynan · 2023-04-17T06:03:37Z

run p0

github-actions

clang-tidy made some suggestions

be/test/vec/data_types/serde/data_type_serde_test.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

amorynan · 2023-04-17T09:34:06Z

run buildall

github-actions · 2023-04-17T09:36:49Z

clang-tidy review says "All clean, LGTM! 👍"

yiguolei

LGTM

fix License

amorynan · 2023-04-17T09:58:20Z

run buildall

github-actions · 2023-04-17T10:05:44Z

clang-tidy review says "All clean, LGTM! 👍"

yiguolei

lgtm

github-actions · 2023-04-18T02:15:03Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-04-18T02:15:06Z

PR approved by anyone and no changes requested.

…pache#18627)

amorynan added 3 commits April 11, 2023 22:22

first commit

c683fe1

update pb

95eb896

update

b6b9285

amorynan changed the title ~~[Refact]( type system) refact serde for type system and pb serde impl~~ [Refact](type system) refact serde for type system and pb serde impl Apr 13, 2023

github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Apr 13, 2023

github-actions bot reviewed Apr 13, 2023

View reviewed changes

fix formate and build pass

a3560bc

github-actions bot reviewed Apr 13, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_serde.cpp Outdated Show resolved Hide resolved

be/src/vec/data_types/serde/data_type_serde.cpp Outdated Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/data_type_struct.h Outdated Show resolved Hide resolved

yiguolei and others added 4 commits April 14, 2023 09:02

Update be/src/vec/data_types/serde/data_type_decimal_serde.h

29e816a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update be/src/vec/data_types/serde/data_type_decimal_serde.h

0509495

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update be/src/vec/data_types/serde/data_type_serde.cpp

00c95d2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update be/src/vec/data_types/serde/data_type_serde.cpp

ce73e82

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_decimal_serde.h Show resolved Hide resolved

be/src/vec/data_types/serde/data_type_serde.cpp Show resolved Hide resolved

be/src/vec/data_types/serde/data_type_serde.cpp Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_bitmap_serde.cpp Outdated Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_bitmap_serde.cpp Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_decimal_serde.h Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/data_types/serde/data_type_hll_serde.cpp Outdated Show resolved Hide resolved

yiguolei reviewed Apr 14, 2023

View reviewed changes

be/src/vec/functions/function_rpc.cpp Outdated Show resolved Hide resolved

fixed

56ef61a

Merge branch 'master' into refact-type-system-base

372aaf8

fix nullable & hll serde and add some ut

5e2dba2

github-actions bot reviewed Apr 17, 2023

View reviewed changes

be/test/vec/data_types/serde/data_type_serde_test.cpp Outdated Show resolved Hide resolved

Update be/test/vec/data_types/serde/data_type_serde_test.cpp

1c64eb6

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

yiguolei previously approved these changes Apr 17, 2023

View reviewed changes

Update data_type_serde_test.cpp

0a73b05

fix License

amorynan dismissed yiguolei’s stale review via 0a73b05 April 17, 2023 09:57

amorynan requested a review from yiguolei April 18, 2023 01:23

yiguolei approved these changes Apr 18, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2023

github-actions bot added the reviewed label Apr 18, 2023

yiguolei merged commit 564446e into apache:master Apr 18, 2023

gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023

[Refact](type system) refact serde for type system and pb serde impl (a…

ecdfaf4

…pache#18627)

Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023

[Refact](type system) refact serde for type system and pb serde impl (a…

9f309be

…pache#18627)

Conversation

amorynan commented Apr 13, 2023

Proposed changes

Problem summary

Checklist(Required)

Further comments

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2023

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

amorynan commented Apr 17, 2023

Uh oh!

hello-stephen commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amorynan commented Apr 17, 2023

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amorynan commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

amorynan commented Apr 17, 2023

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

github-actions bot commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hello-stephen commented Apr 17, 2023 •

edited

Loading